-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: warning shown when parsing delimited date string even if users can't do anything about it #50232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: warning shown when parsing delimited date string even if users can't do anything about it #50232
Conversation
e226268
to
2c0f706
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
are there any contexts where we do want to issue a warning? |
I wouldn't think so, because users can't pass If anything, maybe Timestamp should become stricter and only accept iso8601 strings? |
i meant more along the lines of if the warning should be issued when we are parsing sequences. (so it would need to be issued somewhere else presumably) |
Timestamp doesn't accept sequences, and to_datetime already warns - I've probably misunderstood though, is there another path that accepts sequences that might get here? I'll check more carefully tomorrow |
wasnt aware of that. all good here. |
id be OK with more strict than the status quo (problems have been caused by the parsing code accepting "t2m", though Timestamp still rejects that as OOB for nanosecond reso). iso8601-only is probably too strict for my tastes long long ago i wrote a dateutil-like parser that passed all/most of the dateutill tests and IIRC it was mostly just a handful of regexes (and appreciably more performant). ill see if i can dig that up. |
thanks! merging then |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.